Fix duplicated network interfaces on ESXi provider #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug MTV-1291 describes an issue where, on ESXi providers, opening the modal dialog for changing the migration network for a host may display a list with multiple copies of the same network listed as options. This same issue was not observed with the vCenter endpoint type for the same provider. I managed to reproduce this behavior by simply starting a vm on the host. After the VM boots up, the ESXi provider will emit an ObjectUpdate for the host object which contains ChangeSets that assign new values to the list of PNICs, VNICs, portgroups, and vswitches for that host. It doesn't appear that these values have changed, so it's unclear why we're getting change notifications for them. But, the end result is that every time a vm is started, a duplicate list of networks is being appended to the current list of networks for the host. So when I started a VM 5 times on the host, the list of networks ended up with 5 duplicates of each network interface. When getting object updates from the ESXi server, object values that are array types (such as vswitch, portgroup, pnic, vnic), were being appended to our current list of values for those properties. But since the object update contains the entire list of values for those properties, this ended up adding duplicate values to our list. The solution to the issue is to *replace* our current array of networks with the values that we receive from the object update event rather than appending them to our current array. As far as I can tell, the vCenter provider doesn't seem to trigger the host object update event when a vm starts, which is why the same behavior was not seen for this provider type. But it seems that it would also be susceptible to the same bug if the update did ever occur. Fixes: https://issues.redhat.com/browse/MTV-1291 Signed-off-by: Jonathon Jongsma <[email protected]>
|
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1183 +/- ##
==========================================
- Coverage 15.66% 15.66% -0.01%
==========================================
Files 112 112
Lines 23052 23056 +4
==========================================
Hits 3612 3612
- Misses 19155 19159 +4
Partials 285 285
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mrnold
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug MTV-1291 describes an issue where, on ESXi providers, opening the modal dialog for changing the migration network for a host may display a list with multiple copies of the same network listed as options. This same issue was not observed with the vCenter endpoint type for the same provider.
I managed to reproduce this behavior by simply starting a vm on the host. After the VM boots up, the ESXi provider will emit an ObjectUpdate for the host object which contains ChangeSets that assign new values to the list of PNICs, VNICs, portgroups, and vswitches for that host. It doesn't appear that these values have changed, so it's unclear why we're getting change notifications for them. But, the end result is that every time a vm is started, a duplicate list of networks is being appended to the current list of networks for the host. So when I started a VM 5 times on the host, the list of networks ended up with 5 duplicates of each network interface.
When getting object updates from the ESXi server, object values that are array types (such as vswitch, portgroup, pnic, vnic), were being appended to our current list of values for those properties. But since the object update contains the entire list of values for those properties, this ended up adding duplicate values to our list. The solution to the issue is to replace our current array of networks with the values that we receive from the object update event rather than appending them to our current array.
As far as I can tell, the vCenter provider doesn't seem to trigger the host object update event when a vm starts, which is why the same behavior was not seen for this provider type. But it seems that it would also be susceptible to the same bug if the update did ever occur.
Fixes: https://issues.redhat.com/browse/MTV-1291