Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTV-1571 | Allow to customize the TLS config for the govmomi client #1162

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mnecas
Copy link
Member

@mnecas mnecas commented Oct 31, 2024

Issue:
User can't establish TLS handshake with the vSphere server due to wrong ciphersuite and tls version

Fix:
The user can specify new forklift controller spec:

Ref: https://issues.redhat.com/browse/MTV-1571

@mnecas mnecas requested a review from yaacov as a code owner October 31, 2024 13:40
@mnecas mnecas marked this pull request as draft October 31, 2024 13:40
@mnecas mnecas force-pushed the allow_customize_tls_config branch from aed1f1d to 99e6996 Compare October 31, 2024 13:40
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.

Project coverage is 15.64%. Comparing base (9de3139) to head (7246bb4).

Files with missing lines Patch % Lines
...controller/provider/container/vsphere/collector.go 0.00% 39 Missing ⚠️
pkg/controller/plan/adapter/vsphere/client.go 0.00% 2 Missing ⚠️
pkg/controller/plan/adapter/vsphere/host.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1162      +/-   ##
==========================================
- Coverage   15.71%   15.64%   -0.08%     
==========================================
  Files         112      112              
  Lines       23052    23094      +42     
==========================================
- Hits         3623     3612      -11     
- Misses      19142    19197      +55     
+ Partials      287      285       -2     
Flag Coverage Δ
unittests 15.64% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mnecas mnecas force-pushed the allow_customize_tls_config branch 4 times, most recently from f2dae23 to 196e5a3 Compare November 5, 2024 12:31
@mnecas
Copy link
Member Author

mnecas commented Nov 5, 2024

I have started the inventory pod with TLS_CIPHERS="TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256" TLS_MAX_VERSION="1.2" and go results from Wireshark:
image

@mnecas mnecas force-pushed the allow_customize_tls_config branch from 196e5a3 to f9ccd1b Compare November 5, 2024 13:33
@mnecas mnecas changed the title Allow to customize the TLS config for the govmomi client MTV-1571 | Allow to customize the TLS config for the govmomi client Nov 5, 2024
@mnecas mnecas marked this pull request as ready for review November 5, 2024 15:43
@mnecas mnecas force-pushed the allow_customize_tls_config branch 3 times, most recently from b13d21e to 7246bb4 Compare November 6, 2024 10:08
@mnecas mnecas force-pushed the allow_customize_tls_config branch from 7246bb4 to 7c974fd Compare November 6, 2024 17:11
Copy link

sonarqubecloud bot commented Nov 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants