-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTV-1571 | Allow to customize the TLS config for the govmomi client #1162
base: main
Are you sure you want to change the base?
Conversation
aed1f1d
to
99e6996
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1162 +/- ##
==========================================
- Coverage 15.71% 15.64% -0.08%
==========================================
Files 112 112
Lines 23052 23094 +42
==========================================
- Hits 3623 3612 -11
- Misses 19142 19197 +55
+ Partials 287 285 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f2dae23
to
196e5a3
Compare
196e5a3
to
f9ccd1b
Compare
b13d21e
to
7246bb4
Compare
Signed-off-by: Martin Necas <[email protected]>
7246bb4
to
7c974fd
Compare
Quality Gate passedIssues Measures |
Issue:
User can't establish TLS handshake with the vSphere server due to wrong ciphersuite and tls version
Fix:
The user can specify new forklift controller spec:
vsphere_tls_ciphers
- needs to follow the cipher suites from https://go.dev/src/crypto/tls/cipher_suites.govsphere_tls_max_version
- needs to be one of (1.0
,1.1
,1.2
,1.3
)Ref: https://issues.redhat.com/browse/MTV-1571