MTV-1477 | Add DataVolume deletion when archiving #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: When running the migration archive we do not delete the DataVolumes. Fix: Add deletion of the DataVolumes when running the archive and the VM migration failed. At some cases the migration in the context is missing the migration ID so we can use the plan instead to find the DataVolume. Fixes: https://issues.redhat.com/browse/MTV-1477 Signed-off-by: Martin Necas <[email protected]>
yaacov
approved these changes
Oct 8, 2024
yaacov
reviewed
Oct 8, 2024
|
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1091 +/- ##
==========================================
- Coverage 16.21% 16.17% -0.04%
==========================================
Files 112 112
Lines 19874 19876 +2
==========================================
- Hits 3222 3215 -7
- Misses 16367 16374 +7
- Partials 285 287 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When running the migration archive we do not delete the DataVolumes.
Fix:
Add deletion of the DataVolumes when running the archive and the VM migration failed.
At some cases the migration in the context is missing the migration ID so we can use the plan instead to find the DataVolume.
Fixes: https://issues.redhat.com/browse/MTV-1477