Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warm migration windows static ip #1066

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

mnecas
Copy link
Member

@mnecas mnecas commented Sep 20, 2024

Issue:
The windows is missing the static IP address mapping.

Fix:
Add the --mac mapping so the virt-v2v-in-place flow.

@mnecas mnecas requested a review from yaacov as a code owner September 20, 2024 14:43
Copy link

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 16.28%. Comparing base (f3ea9bf) to head (d0e2857).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
virt-v2v/cmd/entrypoint.go 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1066      +/-   ##
==========================================
- Coverage   16.28%   16.28%   -0.01%     
==========================================
  Files         112      112              
  Lines       19771    19774       +3     
==========================================
  Hits         3220     3220              
- Misses      16267    16270       +3     
  Partials      284      284              
Flag Coverage Δ
unittests 16.28% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yaacov yaacov merged commit 36b19e6 into kubev2v:main Sep 23, 2024
22 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants