Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Containerfile for validation #1050

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

ernesgonzalez33
Copy link
Contributor

No description provided.

@ernesgonzalez33
Copy link
Contributor Author

@mnecas @yaacov I'm not able to build this:

❯ podman build . -f build/validation/Containerfile 
[1/2] STEP 1/6: FROM registry.access.redhat.com/ubi9/go-toolset:1.21.11-9 AS forklift-opa
[1/2] STEP 2/6: WORKDIR /opa/app
--> Using cache ceda26e99c6bdaf8699d9af355145aaa9748c1f99279890dbbf72fd600ee9b78
--> ceda26e99c6b
[1/2] STEP 3/6: COPY --chown=1001:0 ./ ./
--> d9d912360975
[1/2] STEP 4/6: ENV GOFLAGS "-mod=vendor -tags=strictfipsruntime"
--> 5a84419eac36
[1/2] STEP 5/6: ENV GOEXPERIMENT strictfipsruntime
--> f8f9f4d2f252
[1/2] STEP 6/6: RUN GOOS=linux GOARCH=amd64 go build -ldflags="-w -s" -o /tmp/opa github.com/open-policy-agent/opa
cannot find module providing package github.com/open-policy-agent/opa: import lookup disabled by -mod=vendor
Error: building at STEP "RUN GOOS=linux GOARCH=amd64 go build -ldflags="-w -s" -o /tmp/opa github.com/open-policy-agent/opa": while running runtime: exit status 1

It asks for the open-policy-agent dependency in the vendor folder and it is actually not there. But trying to add it using go get ... and then go mod vendor changes a lot of things

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.28%. Comparing base (db6782b) to head (b3cc2ab).
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1050      +/-   ##
==========================================
- Coverage   16.33%   16.28%   -0.05%     
==========================================
  Files         112      112              
  Lines       19771    19771              
==========================================
- Hits         3229     3220       -9     
- Misses      16256    16267      +11     
+ Partials      286      284       -2     
Flag Coverage Δ
unittests 16.28% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ernesgonzalez33 ernesgonzalez33 marked this pull request as ready for review September 20, 2024 08:54
Copy link

Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mnecas mnecas merged commit 465d16e into kubev2v:main Sep 20, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants