Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Dockerfile for oVirt populator #1043

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

ernesgonzalez33
Copy link
Contributor

I based the creation of the Dockerfile on this file and that is why I'm using pip install to install those dependencies. There is another way by using this copr repo @mnecas @yaacov LMK what you guys prefer

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots

See analysis details on SonarCloud

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.32%. Comparing base (b7501bc) to head (831c5b8).
Report is 13 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1043      +/-   ##
==========================================
- Coverage   16.35%   16.32%   -0.04%     
==========================================
  Files         110      112       +2     
  Lines       19675    19771      +96     
==========================================
+ Hits         3218     3227       +9     
- Misses      16174    16257      +83     
- Partials      283      287       +4     
Flag Coverage Δ
unittests 16.32% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ernesgonzalez33 ernesgonzalez33 force-pushed the forklift-rhv-populator-konflux branch from de14d73 to 4bbd273 Compare September 19, 2024 10:44
@ernesgonzalez33
Copy link
Contributor Author

@mnecas @yaacov PTAL

Copy link
Member

@yaacov yaacov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ernesgonzalez33 ernesgonzalez33 force-pushed the forklift-rhv-populator-konflux branch from 4bbd273 to b058bde Compare September 19, 2024 14:36
@ernesgonzalez33 ernesgonzalez33 force-pushed the forklift-rhv-populator-konflux branch from b058bde to 831c5b8 Compare September 19, 2024 14:37
@mnecas mnecas merged commit 717a758 into kubev2v:main Sep 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants