Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run,test: Fix netplan test #1041

Merged
merged 3 commits into from
Sep 19, 2024
Merged

run,test: Fix netplan test #1041

merged 3 commits into from
Sep 19, 2024

Conversation

fabiand
Copy link
Contributor

@fabiand fabiand commented Sep 18, 2024

A small fix to make the netplan tests run as well.

This works y faking the netplan binary.

Signed-off-by: Fabian Deutsch <[email protected]>
Signed-off-by: Fabian Deutsch <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@650d73d). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1041   +/-   ##
=======================================
  Coverage        ?   16.25%           
=======================================
  Files           ?      111           
  Lines           ?    19750           
  Branches        ?        0           
=======================================
  Hits            ?     3210           
  Misses          ?    16259           
  Partials        ?      281           
Flag Coverage Δ
unittests 16.25% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Copy link
Member

@yaacov yaacov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaacov yaacov merged commit 20b1d92 into kubev2v:main Sep 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants