Add netplan config parding sh utility for ubuntu static ip #1026
Conversation
yaacov
force-pushed
the
add-netplan-config-parsing
branch
from
c36f80e to
b0d181a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1026 +/- ##
=======================================
Coverage ? 16.47%
=======================================
Files ? 107
Lines ? 19645
Branches ? 0
=======================================
Hits ? 3237
Misses ? 16117
Partials ? 291
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
With the following script we loop over all configured interfaces and output the one for the given IP address $ IP_TO_FIND=10.0.2.15
$ netplan get ethernets | grep -Eo "^[^[:space:]]+[^:]" | while read IFNAME ; do netplan get ethernets.$IFNAME.addresses | grep -q $IP_TO_FIND && echo $IFNAME ; done |
yaacov
force-pushed
the
add-netplan-config-parsing
branch
4 times, most recently
from
8fc6c77 to
ec77001
Compare
Signed-off-by: yaacov <[email protected]>
yaacov
force-pushed
the
add-netplan-config-parsing
branch
from
ec77001 to
c237860
Compare
| while IFS= read -r line; do | ||
| echo "$line" | ||
| done < "$V2V_MAP_FILE" |
There was a problem hiding this comment.
I think this is equal to cat $V2V_MAP_FILE as we just echo every line without modifications.
In the original code I was modifying the line to convert them into ENV_KEY=VALUE format to then export them iwth export
| # Loop through all interfaces and check for the given IP address | ||
| netplan_get ethernets | grep -Eo "^[^[:space:]]+[^:]" | while read IFNAME; do | ||
| if netplan_get ethernets."$IFNAME".addresses | grep -q "$target_ip"; then | ||
| echo "$IFNAME" |
There was a problem hiding this comment.
either we should return here
or later we need to check that we only found one ifname
|
|
||
| # If S_HW and S_IP were not extracted, skip the line | ||
| if [ -z "$S_HW" ] || [ -z "$S_IP" ]; then | ||
| continue |
There was a problem hiding this comment.
worth adding a log message?
There was a problem hiding this comment.
added logs for invalid mac to ip lines
|
|
||
| # If no interface is found, skip this entry | ||
| if [ -z "$interface_name" ]; then | ||
| continue |
There was a problem hiding this comment.
worth adding a log message?
There was a problem hiding this comment.
added logs for device not found
Signed-off-by: yaacov <[email protected]>
Signed-off-by: yaacov <[email protected]>
Signed-off-by: yaacov <[email protected]>
Signed-off-by: yaacov <[email protected]>
|
Add netplan config parding sh utility for ubuntu static ip