Respect unsecured connections to vSphere #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client to vSphere didn't respect the value to use insecure connections. Now, it will be taken out from the secret and will be respected. Signed-off-by: Liran Rotenberg <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
bkhizgiy
approved these changes
Nov 20, 2023
ahadas
added a commit
to ahadas/forklift
that referenced
this pull request
Jan 3, 2024
Currently, all validations fail because we cannot access the hosts with secure connections. In kubev2v#656 the code has changed to take the configuration of the client connection from the secret, however, the secret of the ESXi hosts is never set with the insecure flag. This change practically makes the client to the hosts be always insecure. It's not that significant because the data we get from the host does not include data that could be confidential. Signed-off-by: Arik Hadas <[email protected]>
ahadas
added a commit
that referenced
this pull request
Jan 4, 2024
Currently, all validations fail because we cannot access the hosts with secure connections. In #656 the code has changed to take the configuration of the client connection from the secret, however, the secret of the ESXi hosts is never set with the insecure flag. This change practically makes the client to the hosts be always insecure. It's not that significant because the data we get from the host does not include data that could be confidential. Signed-off-by: Arik Hadas <[email protected]>
ahadas
added a commit
to ahadas/forklift
that referenced
this pull request
Jan 4, 2024
Currently, all validations fail because we cannot access the hosts with secure connections. In kubev2v#656 the code has changed to take the configuration of the client connection from the secret, however, the secret of the ESXi hosts is never set with the insecure flag. This change practically makes the client to the hosts be always insecure. It's not that significant because the data we get from the host does not include data that could be confidential. Signed-off-by: Arik Hadas <[email protected]>
ahadas
added a commit
to ahadas/forklift
that referenced
this pull request
Jan 4, 2024
Currently, all validations fail because we cannot access the hosts with secure connections. In kubev2v#656 the code has changed to take the configuration of the client connection from the secret, however, the secret of the ESXi hosts is never set with the insecure flag. This change practically makes the client to the hosts be always insecure. It's not that significant because the data we get from the host does not include data that could be confidential. Signed-off-by: Arik Hadas <[email protected]>
ahadas
added a commit
that referenced
this pull request
Jan 4, 2024
Currently, all validations fail because we cannot access the hosts with secure connections. In #656 the code has changed to take the configuration of the client connection from the secret, however, the secret of the ESXi hosts is never set with the insecure flag. This change practically makes the client to the hosts be always insecure. It's not that significant because the data we get from the host does not include data that could be confidential. Signed-off-by: Arik Hadas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client to vSphere didn't respect the value to use insecure connections. Now, it will be taken out from the secret and will be respected.