Skip to content

Commit

Permalink
Fix validation of ESXi network configuration
Browse files Browse the repository at this point in the history
Currently, all validations fail because we cannot access the hosts with
secure connections. In #656 the
code has changed to take the configuration of the client connection from
the secret, however, the secret of the ESXi hosts is never set with the
insecure flag.

This change practically makes the client to the hosts be always
insecure. It's not that significant because the data we get from the
host does not include data that could be confidential.

Signed-off-by: Arik Hadas <[email protected]>
  • Loading branch information
ahadas committed Jan 4, 2024
1 parent ab8a04a commit a2ec605
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/controller/plan/adapter/vsphere/host.go
Original file line number Diff line number Diff line change
Expand Up @@ -155,12 +155,12 @@ func (r *EsxHost) thumbprint() string {
func (r *EsxHost) getInsecureSkipVerifyFlag() bool {
insecure, found := r.Secret.Data["insecureSkipVerify"]
if !found {
return false
return true
}

insecureSkipVerify, err := strconv.ParseBool(string(insecure))
if err != nil {
return false
return true
}

return insecureSkipVerify
Expand Down

0 comments on commit a2ec605

Please sign in to comment.