Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openstack: wait for volume to be removed #591

Merged
merged 4 commits into from
Dec 25, 2023
Merged

openstack: wait for volume to be removed #591

merged 4 commits into from
Dec 25, 2023

Conversation

bennyz
Copy link
Member

@bennyz bennyz commented Sep 13, 2023

Before removing the snapshot attempt to make sure the volume has been removed

@bennyz bennyz force-pushed the openstack-cleanup branch 2 times, most recently from aae764a to 67981c2 Compare September 20, 2023 11:28
@bennyz bennyz force-pushed the openstack-cleanup branch from 67981c2 to a3351eb Compare October 2, 2023 08:06
@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
4.9% 4.9% Duplication

@ahadas ahadas added this to the 2.6.0 milestone Oct 15, 2023
@ahadas
Copy link
Member

ahadas commented Oct 29, 2023

@bennyz I've noticed we had another issue with the snapshot status here, could you please take a look?

@bennyz
Copy link
Member Author

bennyz commented Oct 29, 2023

@bennyz I've noticed we had another issue with the snapshot status here, could you please take a look?

looks like the usual env issues

@ahadas
Copy link
Member

ahadas commented Oct 29, 2023

@bennyz I've noticed we had another issue with the snapshot status here, could you please take a look?

looks like the usual env issues

I didn't see it for a while.. and what was the problem in that case with the snapshot?..

@bennyz
Copy link
Member Author

bennyz commented Oct 30, 2023

@bennyz I've noticed we had another issue with the snapshot status here, could you please take a look?

looks like the usual env issues

I didn't see it for a while.. and what was the problem in that case with the snapshot?..

I only see stuff like

2023-10-29 08:06:34.833 1313 ERROR oslo.messaging._drivers.impl_rabbit [-] [13679efd-cea0-4a1e-b931-4d48e7ac28e4] AMQP server on 127.0.0.1:5672 is unreachable: Too many heartbeats missed. Trying again in 1 seconds.: amqp.exceptions.ConnectionForced: Too many heartbeats missed

@bennyz bennyz force-pushed the openstack-cleanup branch 3 times, most recently from a7f8e7d to b52a528 Compare December 25, 2023 14:47
@bennyz @ahadas
openstack: wait for volume to be removed
c7caf19 
Before removing the snapshot attempt to make sure the volume has been
removed

Signed-off-by: Benny Zlotnik <[email protected]>
@bennyz @ahadas
openstack: add log
0e2fb7f 
Signed-off-by: Benny Zlotnik <[email protected]>
@bennyz @ahadas
fix linter complaint
39aadf6 
Signed-off-by: Benny Zlotnik <[email protected]>
@bennyz @ahadas
openstack: add config for retry attempts
ecfa9f0 
Signed-off-by: Benny Zlotnik <[email protected]>
@ahadas ahadas marked this pull request as ready for review December 25, 2023 15:19
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 25, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
5.4% Duplication on New Code

See analysis details on SonarCloud

@ahadas ahadas merged commit 7b2fb80 into kubev2v:main Dec 25, 2023
10 checks passed
@ahadas ahadas mentioned this pull request Dec 25, 2023
Merged
@bennyz bennyz deleted the openstack-cleanup branch December 26, 2023 12:01
@ahadas ahadas removed this from the 2.6.0 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahadas ahadas ahadas approved these changes

@liranr23 liranr23 Awaiting requested review from liranr23

@bkhizgiy bkhizgiy Awaiting requested review from bkhizgiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bennyz @ahadas