Skip to content

Commit

Permalink
Replace post-vendor.sh with a .gitignore rule
Browse files Browse the repository at this point in the history
It's hard to enforce developers to use `make vendor` so dropping the
post-vendor.sh script that removed unused files that introduce warning
by code analyze tools and we will use .gitignore rules instead.

Signed-off-by: Arik Hadas <[email protected]>
  • Loading branch information
ahadas committed Nov 28, 2023
1 parent d70b67d commit 8ebc20d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,6 @@ bazel-*

# deploy env
hack/deploy/**/deploy.env

# unused Dockerfiles
vendor/**/Dockerfile
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ tidy:
# Run go mod vendor against code
vendor:
go mod vendor
./hack/post-vendor.sh

# Generate code
generate: controller-gen
Expand Down
4 changes: 0 additions & 4 deletions hack/post-vendor.sh

This file was deleted.

0 comments on commit 8ebc20d

Please sign in to comment.