Add a check to the LUKS secret existence

Instead of the plan keep being running and the conversion pod try to init, we can query and check the secret existence for LUKS keys before. In the case it's doesn't exist, fail the migration properly. Signed-off-by: Liran Rotenberg <[email protected]>
kubev2v · May 29, 2024 · 6afd76a · 6afd76a
1 parent abcddd7
commit 6afd76a
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/pkg/controller/plan/kubevirt.go b/pkg/controller/plan/kubevirt.go
@@ -1760,6 +1760,11 @@ func (r *KubeVirt) podVolumeMounts(vmVolumes []cnv.Volume, configMap *core.Confi
 		},
 	})
 	if vm.LUKS.Name != "" {
+		err = r.isSecretExist(vm.LUKS.Name, r.Plan.Spec.TargetNamespace)
+		if err != nil {
+			err = liberr.Wrap(err)
+			return
+		}
 		volumes = append(volumes, core.Volume{
 			Name: "luks",
 			VolumeSource: core.VolumeSource{
@@ -1956,6 +1961,12 @@ func (r *KubeVirt) secretDataSetterForCDI(vmRef ref.Ref) func(*core.Secret) erro
 	}
 }
 
+func (r *KubeVirt) isSecretExist(name, namespace string) (err error) {
+	secret := &core.Secret{}
+	err = r.Destination.Client.Get(context.TODO(), client.ObjectKey{Name: name, Namespace: namespace}, secret)
+	return
+}
+
 // Ensure the credential secret for the data transfer exists on the destination.
 func (r *KubeVirt) ensureSecret(vmRef ref.Ref, setSecretData func(*core.Secret) error) (secret *core.Secret, err error) {
 	_, err = r.Source.Inventory.VM(&vmRef)