Skip to content

Commit

Permalink
ovirt: preserve disk's serial
Browse files Browse the repository at this point in the history
In oVirt, the 'serial' of disks is set to their disk ID. We have noticed
that it could be useful for users to preserve the serial that is set in
oVirt in order to maintain correlations between disks and their
configuration within the guest operating system so we now provide the
'serial' as an input to KubeVirt to achieve this.

[1] https://github.com/oVirt/ovirt-engine/blame/ovirt-engine-4.5.3.z/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java#L2215

Signed-off-by: Arik Hadas <[email protected]>
  • Loading branch information
ahadas committed Jul 24, 2024
1 parent b5659b4 commit 67897c2
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pkg/controller/plan/adapter/ovirt/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,7 @@ func (r *Builder) mapDisks(vm *model.Workload, persistentVolumeClaims []*core.Pe
Bus: cnv.DiskBus(bus),
},
},
Serial: da.Disk.ID,
}
}
volume := cnv.Volume{
Expand Down

0 comments on commit 67897c2

Please sign in to comment.