Reduce cognitive complexity in Migration#Cancel

Signed-off-by: Arik Hadas <[email protected]>
kubev2v · Oct 22, 2023 · 663db1e · 663db1e
1 parent 26993cb
commit 663db1e
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/pkg/controller/plan/migration.go b/pkg/controller/plan/migration.go
@@ -403,17 +403,21 @@ func (r *Migration) Cancel() error {
 				}
 			}
 			vm.MarkCompleted()
-			for _, step := range vm.Pipeline {
-				if step.MarkedStarted() {
-					step.MarkCompleted()
-				}
-			}
+			markStartedStepsCompleted(vm.Pipeline)
 		}
 	}
 
 	return nil
 }
 
+func markStartedStepsCompleted(steps []*plan.Step) {
+	for _, step := range steps {
+		if step.MarkedStarted() {
+			step.MarkCompleted()
+		}
+	}
+}
+
 func (r *Migration) deletePopulatorPVCs(vm *plan.VMStatus) (err error) {
 	if r.builder.SupportsVolumePopulators() {
 		err = r.kubevirt.DeletePopulatedPVCs(vm)