Skip to content

Commit

Permalink
Add 'app' label to the template of the migrated VM
Browse files Browse the repository at this point in the history
This label is used for identification of the virtual machine instance(s)
that will be created from the VM, for example for load balancing, see:

https://github.com/rhpds/roadshow_ocpvirt_instructions/blob/d3b008cb5d7855b54ab912dda9f8d174dd93dcbc/workshop/content/08_migrate_vms.adoc#review-and-configure-migrated-virtual-machines

Signed-off-by: Arik Hadas <[email protected]>
  • Loading branch information
ahadas committed Dec 10, 2023
1 parent 909e8b5 commit 1edba22
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions pkg/controller/plan/kubevirt.go
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ func (r *KubeVirt) EnsureVM(vm *plan.VMStatus) (err error) {
return
}

virtualMachine := &cnv.VirtualMachine{}
var virtualMachine *cnv.VirtualMachine
if len(list.Items) == 0 {
virtualMachine = newVM
err = r.Destination.Client.Create(context.TODO(), virtualMachine)
Expand Down Expand Up @@ -986,6 +986,12 @@ func (r *KubeVirt) virtualMachine(vm *plan.VMStatus) (object *cnv.VirtualMachine
object = r.emptyVm(vm)
}

if object.Spec.Template.ObjectMeta.Labels == nil {
object.Spec.Template.ObjectMeta.Labels = map[string]string{}
}
// Set the 'app' label for identification of the virtual machine instance(s)
object.Spec.Template.ObjectMeta.Labels["app"] = vm.Name

//Add the original name and ID info to the VM annotations
if len(originalName) > 0 {
annotations := make(map[string]string)
Expand Down Expand Up @@ -1075,7 +1081,9 @@ func (r *KubeVirt) emptyVm(vm *plan.VMStatus) (virtualMachine *cnv.VirtualMachin
Labels: r.vmLabels(vm.Ref),
Name: vm.Name,
},
Spec: cnv.VirtualMachineSpec{},
Spec: cnv.VirtualMachineSpec{
Template: &cnv.VirtualMachineInstanceTemplateSpec{},
},
}
return
}
Expand Down

0 comments on commit 1edba22

Please sign in to comment.