Skip querying preference if OS is empty

We may have VM without OS set. In such case we get an empty string from the map. This patch will prevent querying and erroring when we hit this case. Signed-off-by: Liran Rotenberg <[email protected]>
kubev2v · Apr 17, 2024 · 10e4845 · 10e4845
1 parent 78dddf5
commit 10e4845
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/pkg/controller/plan/kubevirt.go b/pkg/controller/plan/kubevirt.go
@@ -1270,6 +1270,10 @@ func (r *KubeVirt) vmPreference(vm *plan.VMStatus) (virtualMachine *cnv.VirtualM
 	if err != nil {
 		return
 	}
+	if preferenceName == "" {
+		err = liberr.New("couldn't find a corresponding preference", "vm", vm)
+		return
+	}
 
 	preferenceName, kind, err := r.getPreference(vm, preferenceName)
 	if err != nil {