feat: add receiver for notification #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gentleelephant <[email protected]>
Gentleelephant
force-pushed
the
fix-1219
branch
from
88d122a to
ba6f0c6
Compare
benjaminhuo
reviewed
Dec 23, 2024
| @@ -125,7 +130,9 @@ func (s *notifyStage) Exec(ctx context.Context, l log.Logger, data interface{}) | |||
| func (s *notifyStage) addExtensionLabels(receiver internal.Receiver, data []*template.Data) { | |||
| for _, d := range data { | |||
| for _, alert := range d.Alerts { | |||
| alert.Labels[constants.ReceiverName] = receiver.GetName() | |||
| if alert.Labels[constants.ReceiverName] == "" { | |||
| alert.Labels[constants.ReceiverName] = receiver.GetName() | |||
There was a problem hiding this comment.
能把 receiver 的 type 也加上吗，比如 slack 还是 wechat
- Add ReceiverType constant in constants.go - Update notify.go to set ReceiverType label for alerts Signed-off-by: Gentleelephant <[email protected]>
benjaminhuo
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.