Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assign container computation errors to the 1st step requiring it #5977

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Oct 28, 2024

Pull request description

  • Errors for container data (i.e. setting some environment variable to {{ unknownFunc }}) are now not displayed in the step
    • This change is pushing the error information down to the first step after
kind: TestWorkflow
apiVersion: testworkflows.testkube.io/v1
metadata:
  name: example
spec:
  steps:
  - container:
      env:
      - name: XYZ
        value: '{{ unknownFunc }}'
    shell: echo hello

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

@rangoo94 rangoo94 requested a review from a team as a code owner October 28, 2024 14:37
@rangoo94 rangoo94 merged commit 234e2c7 into main Oct 28, 2024
24 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/transfer-computation-errors-down branch October 28, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants