Skip to content

Commit

Permalink
Merge branch 'vsukhin/feature/stream-service-logs' into sandbox/twrc
Browse files Browse the repository at this point in the history
  • Loading branch information
vsukhin committed Nov 29, 2024
2 parents c1c77dc + 3e2c45f commit 17b1c82
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions pkg/agent/testworkflows.go
Original file line number Diff line number Diff line change
Expand Up @@ -243,9 +243,6 @@ func (ag *Agent) executeWorkflowNotificationsRequest(ctx context.Context, req *c
}

func (ag *Agent) executeWorkflowServiceNotificationsRequest(ctx context.Context, req *cloud.TestWorkflowServiceNotificationsRequest) error {
timeoutCtx, cancel := context.WithTimeout(ctx, serviceWaitTimeout)
defer cancel()

notificationsCh, err := retry.DoWithData(
func() (<-chan testkube.TestWorkflowExecutionNotification, error) {
// We have a race condition here
Expand All @@ -256,11 +253,10 @@ func (ag *Agent) executeWorkflowServiceNotificationsRequest(ctx context.Context,
},
retry.DelayType(retry.FixedDelay),
retry.Delay(logRetryDelay),
retry.Context(timeoutCtx),
retry.RetryIf(func(err error) bool {
return errors.Is(err, registry.ErrResourceNotFound)
}),
retry.Attempts(0),
retry.UntilSucceeded(),
)

if err != nil {
Expand Down

0 comments on commit 17b1c82

Please sign in to comment.