Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving the way we fetch the api server address #444

Merged
merged 3 commits into from
Dec 22, 2024
Merged

Improving the way we fetch the api server address #444

merged 3 commits into from
Dec 22, 2024

Conversation

amitschendel
Copy link
Collaborator

Overview

@amitschendel amitschendel requested a review from matthyx December 21, 2024 11:21
@amitschendel
Removing non k8s clients
8eb309c 
Signed-off-by: Amit Schendel <[email protected]>
@amitschendel
Fixing test
18ece83 
Signed-off-by: Amit Schendel <[email protected]>
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

matthyx
matthyx approved these changes Dec 21, 2024
View reviewed changes
Copy link
Contributor

@matthyx matthyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to set this in the chart?

@amitschendel
Copy link
Collaborator Author

Do we have to set this in the chart?

No Kubernetes sets this for every container.
More information.

@amitschendel amitschendel merged commit 8ba0c61 into main Dec 22, 2024
19 checks passed
@amitschendel amitschendel deleted the feature/improve-api-addresss branch December 22, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthyx matthyx matthyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amitschendel @matthyx