Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for fork exec to get real process details #440

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Adding support for fork exec to get real process details #440

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5bf6a3
Adding support for fork exec to get real process details
amitschendel Dec 18, 2024
ecd15b7
Fixing typo
amitschendel Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions pkg/processmanager/v1/process_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
const (
cleanupInterval = 1 * time.Minute
maxTreeDepth = 50
runCCommPrefix = "runc:["
)

type ProcessManager struct {
Expand Down Expand Up @@ -275,6 +276,20 @@ func (p *ProcessManager) GetProcessTreeForPID(containerID string, pid int) (apit
}
}

// If the process is runc, try to fetch the real process info.
// Intentionally we are doing this only once the process is asked for to avoid unnecessary calls to /proc and give time for the process to be created.
if strings.HasPrefix(result.Comm, runCCommPrefix) {
if process, err := p.getProcessFromProc(int(result.PID)); err == nil {
childerns := result.Children
upperLayer := result.UpperLayer
result = process
result.Children = childerns
result.UpperLayer = upperLayer
// Update the process in the tree
p.processTree.Set(result.PID, result)
}
}

return result, nil
}

Expand Down
Loading