Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a strict check if the application profile is partial #420

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Adding a strict check if the application profile is partial #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 9 additions & 13 deletions pkg/ruleengine/v1/r0011_unexpected_egress_network_traffic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ import (
"bytes"
"fmt"
"net"
"slices"
"strings"

apitypes "github.com/armosec/armoapi-go/armotypes"
"github.com/goradd/maps"
Expand Down Expand Up @@ -69,13 +67,19 @@ func (rule *R0011UnexpectedEgressNetworkTraffic) handleNetworkEvent(networkEvent
return nil
}

// Skip partially watched containers.
if annotations := nn.GetAnnotations(); annotations != nil {
if annotations["kubescape.io/completion"] == string(utils.WatchedContainerCompletionStatusPartial) {
return nil
}
}

nnContainer, err := getContainerFromNetworkNeighborhood(nn, networkEvent.GetContainer())
if err != nil {
return nil
}

domain := objCache.DnsCache().ResolveIpToDomain(networkEvent.DstEndpoint.Addr)

if domain != "" {
return nil
}
Expand All @@ -85,11 +89,6 @@ func (rule *R0011UnexpectedEgressNetworkTraffic) handleNetworkEvent(networkEvent
if egress.IPAddress == networkEvent.DstEndpoint.Addr {
return nil
}

// Check if we seen this dns name before and it's in-cluster address and in the egress list.
if domain != "" && (strings.HasSuffix(domain, "svc.cluster.local.") || slices.Contains(egress.DNSNames, domain)) {
return nil
}
}

// Alert on the address.
Expand Down Expand Up @@ -163,11 +162,6 @@ func isPrivateIP(ip string) bool {
return true
}

// Check if IP is metadata server
if parsedIP.Equal(net.ParseIP("169.254.169.254")) {
return true
}

// Check if IP is in private IP ranges
privateIPRanges := []struct {
start net.IP
Expand All @@ -180,6 +174,8 @@ func isPrivateIP(ip string) bool {
{net.ParseIP("224.0.0.0"), net.ParseIP("239.255.255.255")},
// Class E (Experimental)
{net.ParseIP("240.0.0.0"), net.ParseIP("255.255.255.255")},
// APIPA (sometimes used for local dns)
{net.ParseIP("169.254.0.0"), net.ParseIP("169.254.255.255")},
}

for _, r := range privateIPRanges {
Expand Down
13 changes: 13 additions & 0 deletions pkg/ruleengine/v1/r0011_unexpected_egress_network_traffic_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,20 @@ func TestR0011UnexpectedNetworkTraffic(t *testing.T) {
t.Errorf("Expected ruleResult to be nil since we already alerted on this port")
}

// Test with non-whitelisted address with nil dns cache with different port. with partial watched container.
e.DstEndpoint.Addr = "5.5.5.5"
e.Port = 81
originalAnnotations := nn.GetAnnotations()
nn.Annotations = map[string]string{"kubescape.io/completion": string(utils.WatchedContainerCompletionStatusPartial)}
objCache.SetNetworkNeighborhood(nn)
ruleResult = r.ProcessEvent(utils.NetworkEventType, e, &objCache)
if ruleResult != nil {
t.Errorf("Expected ruleResult to be nil since it's a partially watched container")
}

// Test with non-whitelisted address with nil dns cache with different port.
nn.Annotations = originalAnnotations
objCache.SetNetworkNeighborhood(nn)
e.DstEndpoint.Addr = "5.5.5.5"
e.Port = 80
e.Proto = "UDP"
Expand Down
Loading