remove ApplicationProfileSummary creation

[matthyx]

User description

we need this before smart remediation GA

---

Type

enhancement, bug_fix

---

Description

• Removed the creation and handling of ApplicationProfileSummary across various components.
• Updated tests to reflect the removal of ApplicationProfileSummary creation.
• Updated StorageClient interface and its implementations to remove CreateApplicationProfileSummary.
• Updated github.com/kubescape/storage dependency to v0.0.69.

---

Changes walkthrough

	Relevant files
Enhancement	applicationprofile_manager.go Remove ApplicationProfileSummary Creation Logic                    pkg/applicationprofilemanager/v1/applicationprofile_manager.go Removed creation of ApplicationProfileSummary in saveProfile function. +0/-18    storage_interface.go Interface Update by Removing CreateApplicationProfileSummary pkg/storage/storage_interface.go Removed CreateApplicationProfileSummary method from StorageClient interface. +0/-1      storage_mock.go Mock Storage Client Update                                                              pkg/storage/storage_mock.go Removed ApplicationProfileSummaries field and CreateApplicationProfileSummary method. +8/-14    storage_nocache.go Remove CreateApplicationProfileSummary Implementation        pkg/storage/v1/storage_nocache.go Removed implementation of CreateApplicationProfileSummary. +0/-8
Tests	applicationprofile_manager_test.go Update Tests for ApplicationProfileSummary Removal              pkg/applicationprofilemanager/v1/applicationprofile_manager_test.go Updated test to reflect removal of ApplicationProfileSummary creation. +0/-1
Dependencies	go.mod Update Kubescape Storage Dependency                                            go.mod Updated github.com/kubescape/storage dependency from v0.0.67 to v0.0.69. +1/-1      go.sum Update Checksums for Storage Dependency                                    go.sum Updated checksums for github.com/kubescape/storage dependency. +2/-2

---

✨ PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-free]

PR Description updated to latest commit (ff8402c)

[codiumai-pr-agent-free]

PR Review

⏱️ Estimated effort to review [1-5]	2, because the changes are straightforward and mainly involve the removal of code related to ApplicationProfileSummary. The modifications are clear and localized to specific functions and interfaces, making the review process less time-consuming.
🧪 Relevant tests	Yes
🔍 Possible issues	Possible Regression: Removing ApplicationProfileSummary creation logic might impact components that rely on these summaries. Ensure all dependent components have been updated or do not require ApplicationProfileSummary.
🔒 Security concerns	No

---

✨ Review tool usage guide:

---

Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.

The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

• When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

• With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

See the review usage page for a comprehensive guide on using this tool.

[codiumai-pr-agent-free]

PR Code Suggestions

Category	Suggestions
Enhancement	Add a new assertion to the test to replace the removed assertion for ApplicationProfileSummaries. Since the creation of ApplicationProfileSummary is removed, the test assertion for the length of ApplicationProfileSummaries is also removed. To ensure the test still validates the state of the system accurately, consider adding a new assertion that checks a different aspect of the system's state that is still relevant. For example, you could assert the length of another slice or the state of a specific object to ensure the system behaves as expected after the removal. pkg/applicationprofilemanager/v1/applicationprofile_manager_test.go [80] -assert.Equal(t, []string{"NET_BIND_SERVICE"}, storageClient.ApplicationProfiles[0].Spec.Containers[1].Capabilities) +// Example of a new assertion that could be added +assert.Equal(t, expectedNumberOfProfiles, len(storageClient.ApplicationProfiles), "The number of application profiles should match the expected value")
Maintainability	Update documentation and interface contracts to reflect the removal of CreateApplicationProfileSummary. With the removal of the CreateApplicationProfileSummary method from the StorageClient interface, it's important to review any documentation or interface contracts that might reference this method. Ensure that all references and documentation are updated to reflect this change. This helps maintain clarity and prevents confusion about the interface's capabilities. pkg/storage/storage_interface.go [12] GetApplicationProfile(namespace, name string) (*v1beta1.ApplicationProfile, error) +// Ensure documentation and interface contracts are updated accordingly
	Ensure all features dependent on CreateApplicationProfileSummary are updated or remain functional. With the removal of the CreateApplicationProfileSummary function, it's essential to ensure that any logic depending on the creation of application profile summaries is either updated or removed. This might involve adjusting how application profiles are handled or ensuring that any dependent features are still functional without the creation of summaries. pkg/storage/v1/storage_nocache.go [175] CreateFilteredSBOM(SBOM *v1beta1.SBOMSyftFiltered) error +// Ensure dependent features are still functional without the creation of application profile summaries
Best practice	Update or remove tests relying on ApplicationProfileSummaries in StorageHttpClientMock. Given that ApplicationProfileSummaries is removed from StorageHttpClientMock, it's a good practice to review and potentially update the mock's usage in tests. Ensure that tests relying on ApplicationProfileSummaries are either updated or removed to reflect this change. This might involve updating test scenarios or adding new ones to cover the updated behavior. pkg/storage/storage_mock.go [27] NetworkNeighborses []*v1beta1.NetworkNeighbors +// Update or remove tests relying on ApplicationProfileSummaries
	Review the release notes or change logs for the updated github.com/kubescape/storage dependency. The update from github.com/kubescape/storage v0.0.67 to v0.0.69 might include changes beyond the removal of ApplicationProfileSummary. It's crucial to review the release notes or change logs of this dependency to understand all changes. This ensures that there are no unexpected side effects or new features that require integration into your project. go.mod [21] github.com/kubescape/storage v0.0.69 +// Review release notes or change logs for this version update

---

✨ Improve tool usage guide:

---

Overview:
The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

• When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:

/improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...

• With a configuration file, use the following template:

[pr_code_suggestions]
some_config1=...
some_config2=...

See the improve usage page for a comprehensive guide on using this tool.

[github-actions]

Summary:

• License scan: failure
• Credentials scan: failure
• Vulnerabilities scan: failure
• Unit test: success
• Go linting: success

[github-actions]

Summary:

• License scan: failure
• Credentials scan: failure
• Vulnerabilities scan: failure
• Unit test: success
• Go linting: success

[github-actions]

Summary:

• License scan: failure
• Credentials scan: failure
• Vulnerabilities scan: failure
• Unit test: success
• Go linting: success