add label with parent resource version

[matthyx]

type:

enhancement

---

description:

This PR introduces several changes to improve the handling of workload resource versions:

• A new field ParentResourceVersion is added to the WatchedContainerData struct in utils.go. This field will store the resource version of the parent workload.
• The getContainerInfo function in relevancy_manager.go is updated to return the parent resource version. This value is then stored in the WatchedContainerData struct.
• The generateNetworkNeighborsLabels function in network_neighbors.go is refactored to include the resource version in the generated labels.
• The ensureInstanceID function in applicationprofile_manager.go is updated to set the ParentResourceVersion field of the WatchedContainerData struct.
• The test cases in network_neighbors_test.go are updated to reflect these changes.
• The k8s-interface dependency in go.mod and go.sum is updated to version v0.0.150.

---

main_files_walkthrough:

files:

• pkg/utils/utils.go: Added a new field ParentResourceVersion to the WatchedContainerData struct.
• pkg/relevancymanager/v1/relevancy_manager.go: Updated the getContainerInfo function to return the parent resource version and store it in the WatchedContainerData struct.
• pkg/networkmanager/network_neighbors.go: Refactored the generateNetworkNeighborsLabels function to include the resource version in the generated labels.
• pkg/applicationprofilemanager/v1/applicationprofile_manager.go: Updated the ensureInstanceID function to set the ParentResourceVersion field of the WatchedContainerData struct.
• pkg/networkmanager/network_neighbors_test.go: Updated test cases to reflect the changes in the generateNetworkNeighborsLabels function.
• go.mod: Updated the k8s-interface dependency to version v0.0.150.
• go.sum: Updated the k8s-interface dependency to version v0.0.150.

[github-actions]

Summary:

• License scan: success
• Credentials scan: success
• Vulnerabilities scan: success
• Unit test: success
• Go linting: success

[github-actions]

Summary:

• License scan: success
• Credentials scan: success
• Vulnerabilities scan: success
• Unit test: success
• Go linting: success

[codiumai-pr-agent-free]

PR Analysis

• 🎯 Main theme: Adding parent resource version to workload data
• 📝 PR summary: This PR introduces a new field ParentResourceVersion to the WatchedContainerData struct and updates several functions to handle this new field. It also updates the k8s-interface dependency to version v0.0.150.
• 📌 Type of PR: Enhancement
• 🧪 Relevant tests added: Yes
• ⏱️ Estimated effort to review [1-5]: 3, because the PR involves changes in multiple files and functions, and understanding the impact of these changes requires a good understanding of the codebase.
• 🔒 Security concerns: No security concerns found

PR Feedback

• 💡 General suggestions: The PR seems well-structured and follows good coding practices. The changes are spread across multiple files, which shows a good understanding of the codebase. However, it would be beneficial to include more context or explanation about why these changes are necessary and how they improve the system.

• 🤖 Code feedback:

  • relevant file: pkg/relevancymanager/v1/relevancy_manager.go
    suggestion: Consider handling the error right after the GetWorkload function call to avoid unnecessary operations in case of an error. [important]
    relevant line: imageID, imageTag, parentWlid, parentResourceVersion, instanceID, err := rm.getContainerInfo(container.K8s.Namespace, container.K8s.PodName, container.K8s.ContainerName)

  • relevant file: pkg/networkmanager/network_neighbors_test.go
    suggestion: It would be beneficial to add more test cases to cover different scenarios and edge cases. [medium]
    relevant line: "kubescape.io/workload-resource-version": "339815",

  • relevant file: pkg/networkmanager/network_neighbors.go
    suggestion: Consider adding error handling or checks for the GetResourceVersion function call. [important]
    relevant line: instanceidhandlerV1.ResourceVersionMetadataKey: workload.GetResourceVersion(),

  • relevant file: pkg/utils/utils.go
    suggestion: It would be beneficial to add checks to ensure that the ParentResourceVersion is valid. [medium]
    relevant line: labels[instanceidhandler2.ResourceVersionMetadataKey] = watchedContainer.ParentResourceVersion

How to use

Instructions

To invoke the PR-Agent, add a comment using one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

[github-actions]

Summary:

• License scan: success
• Credentials scan: success
• Vulnerabilities scan: success
• Unit test: success
• Go linting: success