Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor topics.go to update topic names and add new topic for RuntimeIncident #35

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Refactor topics.go to update topic names and add new topic for RuntimeIncident #35

merged 1 commit into from
Jul 24, 2024

Conversation

kooomix
Copy link
Contributor

@kooomix kooomix commented Jul 24, 2024

No description provided.

@github-actions GitHub Actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: skipped
  • Vulnerabilities scan: skipped
  • Unit test: success
  • Go linting: success

Bezbran
Bezbran approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@Bezbran Bezbran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you have the guid why do you need the details of the incident? in any future change we will take it from the config service since in general the notification should hold only identifiers.

@kooomix kooomix merged commit a0f91a8 into main Jul 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bezbran Bezbran Bezbran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kooomix @Bezbran