-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for complianceThreshold #58
Conversation
PR Description updated to latest commit (ec64e8d) |
PR Analysis
PR Feedback💡 General suggestions: The PR is well-structured and the changes are clear. However, it would be beneficial to include tests to verify the new functionality and ensure it doesn't break existing features. 🤖 Code feedback:
✨ Usage guide:Overview:
With a configuration file, use the following template:
See the review usage page for a comprehensive guide on using this tool. |
@@ -20,10 +20,16 @@ set -e | |||
export KS_CLIENT="github_actions" | |||
|
|||
if [ -n "${INPUT_FRAMEWORKS}" ] && [ -n "${INPUT_CONTROLS}" ]; then | |||
echo "Framework and Control are specified. Please specify either one of them or neither" | |||
echo "Framework and Control are specified. Please specify either one of them" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit remove either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed the script so the user must define either one of them, but if neither the action fails.
If we define neither, as of Kubescape 3.0, we scan the "cluster security framework" (the command which is executed is kubescape scan
without framework or control) and it has no meaning in the use case of the GH action
Type
Enhancement
Description
INPUT_COMPLIANCETHRESHOLD
inentrypoint.sh
. This variable is used to set the compliance threshold for the kubescape scan command.entrypoint.sh
to check if bothINPUT_FAILEDTHRESHOLD
andINPUT_COMPLIANCETHRESHOLD
are specified. If so, an error message is displayed and the script exits.complianceThreshold
inaction.yml
with its description. This input is used to set the compliance threshold for the kubescape scan command.Changes walkthrough
entrypoint.sh
entrypoint.sh
Added support for a new environment variable
INPUT_COMPLIANCETHRESHOLD
. This variable is used to setthe compliance threshold for the kubescape scan command.
Also, added a condition to check if both
INPUT_FAILEDTHRESHOLD
andINPUT_COMPLIANCETHRESHOLD
arespecified, in which case an error message is displayed and
the script exits.
action.yml
action.yml
Added a new input
complianceThreshold
with itsdescription. This input is used to set the compliance
threshold for the kubescape scan command.
✨ Usage guide:
Overview:
The
describe
tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.When commenting, to edit configurations related to the describe tool (
pr_description
section), use the following template:With a configuration file, use the following template:
Enabling\disabling automation
meaning the
describe
tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description.the tool will replace every marker of the form
pr_agent:marker_name
in the PR description with the relevant content, wheremarker_name
is one of the following:type
: the PR type.summary
: the PR summary.walkthrough
: the PR walkthrough.Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.
Custom labels
The default labels of the
describe
tool are quite generic: [Bug fix
,Tests
,Enhancement
,Documentation
,Other
].If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:
Main topic:performance
- pr_agent:The main topic of this PR is performanceNew endpoint
- pr_agent:A new endpoint was added in this PRSQL query
- pr_agent:A new SQL query was added in this PRDockerfile changes
- pr_agent:The PR contains changes in the DockerfileThe list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.
More PR-Agent commands
See the describe usage page for a comprehensive guide on using this tool.