-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcd: add periodic tests ci-etcd-unit-test-amd64 and ci-etcd-robustness-amd64 #32217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @siyuanfoundation - Question re lazyfs below but overall this looks good.
- -c | ||
- | | ||
apt update && apt-get --yes install cmake libfuse3-dev libfuse3-3 fuse3 | ||
sed -i 's/#user_allow_other/user_allow_other/g' /etc/fuse.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we tested this with a local prow instance? I had a lot of trouble getting lazyfs to work within github actions. Curious to see how it behaves here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I have tested this locally. Had some trouble getting lazyfs to work too, but it seems to work after setting privileged: true
…ss-amd64 Signed-off-by: Siyuan Zhang <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: serathius, siyuanfoundation The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@siyuanfoundation: Updated the
In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubernetes/k8s.io#6102