Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump k8s.io dependencies to v0.29.0 #770

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Bump k8s.io dependencies to v0.29.0 #770

merged 2 commits into from
Dec 14, 2023

Conversation

haoranleo
Copy link
Contributor

@haoranleo haoranleo commented Dec 13, 2023 •
edited
Loading

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Bump k8s.io depedencies to v1.29.0, and golang version to 1.21 to start releasing 1.29.
We can create 1.29 release branch starting from this commit.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 13, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @haoranleo!

It looks like this is your first PR to kubernetes/cloud-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 13, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @haoranleo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 13, 2023
@haoranleo
Copy link
Contributor Author

/assign cartermckinnon

@cartermckinnon
Copy link
Contributor

/hold

Discussed offline, we'll wait until the 0.29.0 tags land upstream to avoid extra cycles.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2023
cartermckinnon
cartermckinnon reviewed Dec 13, 2023
View reviewed changes
version.txt Outdated
@@ -1 +1 @@
1.28.0
1.29.0-rc.2
Copy link
Contributor

@cartermckinnon cartermckinnon Dec 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to remove this from this commit. We need to get the dependencies updated on master then I can create the release-1.29 branch that includes that commit -- then we'll tag a release on that branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed the comment, got it sounds good to me

@haoranleo haoranleo changed the title Release v1.29.0-rc.2 Release v1.29.0 Dec 13, 2023
cartermckinnon
cartermckinnon reviewed Dec 13, 2023
View reviewed changes
version.txt Outdated
@@ -1 +1 @@
1.28.0
1.29.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to remove this from this commit, this commit should only update the dependencies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the PR

@cartermckinnon
Copy link
Contributor

/retitle Bump k8s.io dependencies to v0.29.0

@k8s-ci-robot k8s-ci-robot changed the title Release v1.29.0 Bump k8s.io dependencies to v0.29.0 Dec 13, 2023
@cartermckinnon
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 13, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 13, 2023
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 13, 2023
@haoranleo
Copy link
Contributor Author

/retest

Ran these checks locally and succeeded..

@cartermckinnon
Copy link
Contributor

The CI is broken, folks are working on it 👍

@cartermckinnon
Copy link
Contributor

/retest

4 similar comments
@cartermckinnon
Copy link
Contributor

/retest

@cartermckinnon
Copy link
Contributor

/retest

@cartermckinnon
Copy link
Contributor

/retest

@cartermckinnon
Copy link
Contributor

/retest

@torredil
Copy link
Member

/test pull-cloud-provider-aws-e2e-kubetest2-quick

@torredil
Copy link
Member

/retest

@torredil
Copy link
Member

/test pull-cloud-provider-aws-e2e-kubetest2

@torredil
Copy link
Member

/retest

1 similar comment
@torredil
Copy link
Member

/retest

@cartermckinnon
Copy link
Contributor

/hold remove
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cartermckinnon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@cartermckinnon
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4e09b9b into kubernetes:master Dec 14, 2023
13 checks passed
@haoranleo haoranleo deleted the release-1.29.0 branch December 14, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermckinnon cartermckinnon cartermckinnon left review comments

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

@nckturner nckturner Awaiting requested review from nckturner

Assignees

@cartermckinnon cartermckinnon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haoranleo @k8s-ci-robot @cartermckinnon @torredil