Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image promotion instructions #592

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

puerco
Copy link
Member

@puerco puerco commented Jul 12, 2022

What type of PR is this?

/kind documentation

What this PR does / why we need it:

This commit updates the RELEASE.md doc to add image promotion
instructions.

Signed-off-by: Adolfo García Veytia (Puerco) [email protected]

Which issue(s) this PR fixes:

Part of: #591

Special notes for your reviewer:

/cc @kubernetes-sigs/release-engineering

Does this PR introduce a user-facing change?

Added documentation about promoting the promoter container images

@k8s-ci-robot k8s-ci-robot requested a review from a team July 12, 2022 03:47
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects labels Jul 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 12, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 12, 2022
@Verolop
Copy link

Verolop commented Jul 12, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2022
This commit updates the RELEASE.md doc to add image promotion
instructions.

Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2022
@puerco puerco changed the title Docs: Add image promotions instructions Docs: Add image promotion instructions Jul 12, 2022
@puerco
Copy link
Member Author

puerco commented Jul 12, 2022

Thanks @Verolop! (I pushed a typo fix and lost the /lgtm PTAL!)

@Verolop
Copy link

Verolop commented Jul 12, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2022
@puerco puerco changed the title Docs: Add image promotion instructions Image promotion instructions Jul 12, 2022
@puerco
Copy link
Member Author

puerco commented Jul 12, 2022

/test pull-cip-e2e

@k8s-ci-robot k8s-ci-robot merged commit 6bdec78 into kubernetes-sigs:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants