Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helm charts for lws. #266

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add helm charts for lws. #266

wants to merge 1 commit into from

Conversation

wqlparallel
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it

Added helm charts for lws.

Which issue(s) this PR fixes

Fixes #260

Special notes for your reviewer

Does this PR introduce a user-facing change?

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wqlparallel
Once this PR has been reviewed and has the lgtm label, please assign kerthcet for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 24, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @wqlparallel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 24, 2024
@kannon92
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 24, 2024
kannon92
kannon92 reviewed Nov 25, 2024
View reviewed changes
charts/lws/README.md Outdated
##### Install chart using Helm v3.0+

```bash
$ git clone [email protected]:kubernetes-sigs/kueue.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$ git clone [email protected]:kubernetes-sigs/kueue.git
$ git clone [email protected]:kubernetes-sigs/lws.git

kannon92
kannon92 reviewed Nov 25, 2024
View reviewed changes
charts/lws/README.md Outdated
##### Verify that controller pods are running properly.

```bash
$ kubectl get deploy -n kueue-system
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$ kubectl get deploy -n kueue-system
$ kubectl get deploy lws-system

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry，I referenced the queue project during development because the helm charts for queue and lws are quite similar. I've corrected the submission now. The helm chart has been tested and appears to be functioning correctly.

@wqlparallel
Add helm charts for lws.
d2bcf84 
Signed-off-by: wqlparallel <[email protected]>
@kerthcet
Copy link
Contributor

/hold

Put my concern here: #260 (comment)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 kannon92 left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

@liurupeng liurupeng Awaiting requested review from liurupeng

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding Helm Chart for lws
4 participants
@wqlparallel @k8s-ci-robot @kannon92 @kerthcet