-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix handling for multiple Daemonset nodeAffinity selectorTerms #1727
base: main
Are you sure you want to change the base?
fix: Fix handling for multiple Daemonset nodeAffinity selectorTerms #1727
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 11130811960Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
return true | ||
} | ||
} | ||
return false | ||
} | ||
|
||
func (p *Preferences) removePreferredNodeAffinityTerm(pod *v1.Pod) *string { | ||
func (p *Preferences) RemovePreferredNodeAffinityTerm(pod *v1.Pod) *string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why export all these functions?
Hey @jonathan-innis any update on the following PR we are really waiting for this fix to land so we can use karpenter on our clusters currently this is a huge blocked for us |
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Would love to see this get merged as well @jonathan-innis. |
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Fixes #1337
Description
This change ensures that we consider all nodeAffinity terms when determining if the DS is going to schedule to the node.
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.