-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Able to run controller inside the container platform with write access to root restrictions #322
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dmvolod The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @dmvolod. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up! Is the idea here just to mount the /xdg path and expect the user or management cluster to populate it? And are you able to test this with OpenShift and verify that it works?
Yes, I also changed the container security parameter |
@Jont828 could you please to point me to the deployed addon prodived helm container pod logs in failed CI. |
Oh, ran it locally and know why it happens, /tmp is also using as rw volume. Will fix soon. |
…ess to root restrictions
- emptyDir: {} | ||
name: xdg | ||
- emptyDir: {} | ||
name: tmp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use single tmp volume mounted to the /tmp
and utilize it for all temporary files (common and XDG based). @Jont828 what do you think about it? This should work for all Kubernetes platforms and security restrictions
What this PR does / why we need it:
This fix allows you to run a container with an operator on platforms that do not allow writing data to the root directory, such as OpenShift.
The approach used is very simple, we mount /xdg as an emptyDir volume and redirect XDG_* variables used by helm there. This should work for upstream Kubernetes as well, but e2e validation is required.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #236