-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support disk discovery on Windows Gen2 and v6 VM sku #2671
base: master
Are you sure you want to change the base?
fix: support disk discovery on Windows Gen2 and v6 VM sku #2671
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
fb0a86f
to
3265997
Compare
/retest |
f43c544
to
34b3a33
Compare
/retest |
add logging fix fix fix
34b3a33
to
7c070fe
Compare
/retest |
@andyzhangx: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: support disk discovery on Windows Gen2 and v6 VM sku
Windows team provided the following info:
"Model": "Microsoft Virtual Disk"
"Model": "Virtual_Disk NVME Premium"
thus I think we could use this filter:
ConvertTo-Json @(Get-CimInstance win32_diskdrive | Where-Object { $_.Model -eq "Virtual_Disk NVME Premium" -or $_.SCSIPort -Ne 0 } | Select-Object Index, SCSILogicalUnit, SCSITargetId, SCSIPort, SCSIBus, Model)
, thus we could fix this issue permanently.Which issue(s) this PR fixes:
Fixes #2365, #2661
Requirements:
Special notes for your reviewer:
Release note: