Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disk: attach disks with serial number at controller #1199

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

disk: attach disks with serial number at controller #1199

wants to merge 2 commits into from

Commits on Nov 1, 2024

  1. disk/device_manager: take serial number 

    Don't assume the serial is the volume ID without "d-" prefix.
    @huww98
    huww98 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    7547252 View commit details
    Browse the repository at this point in the history

  2. disk: attach&detach disks with serial number at controller 

    Attach and detach must be migrated at once, because NodeUnstageVolume may be followed immediately by anoterh NodeStageVolume, without controller actions.
So if we detach disk at NodeUnstageVolume, NodeStageVolume will not find the disk.

Note: user must upgrade controller before node, to avoid any missing detach.

This is the first step to move all attach/detach back to controller, in order to:
- reduce RAM permission on node
- more effective request batching
- rely less on node, which can be down
- resolve some rare racing issue
    @huww98
    huww98 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    30d433a View commit details
    Browse the repository at this point in the history