Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Kubevirt provider implementation #3416

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Initial Kubevirt provider implementation #3416

merged 1 commit into from
Oct 31, 2024

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Oct 25, 2024

What this PR does / why we need it:

This PR implements the initial and very minimal Kubevirt provider for KubeOne. The purposes of this implementation is to mitigate the issue outlined in #3366, i.e. to allow using machine-controller and operating-system-manager for Kubevirt clusters.

I initially though about reading supported environment variables and putting them in the secret if cloud provider is none, but it has two very big problems:

  • We would start deploying arbitrary environment variables to the cluster, that are very likely not even related to that cluster
  • We don't have a way to validate what environment variables are needed, e.g. there's no way to know that we need KUBEVIRT_KUBECONFIG for the said cluster that uses cloud provider none
    • This can make a huge trouble if someone runs kubeone apply without setting the needed environment variables, in which case the value would be removed from the cluster and machine-controller would start failing

Because of the given reasons, I thought that it's much safer to implement a very minimalistic provider for Kubevirt that doesn't have Terraform integration and support for CCM/CSI, but that can be used as a way to deploy machine-controller and operating-system-manager in a safe and reliable way.

Which issue(s) this PR fixes:
xref #3366

What type of PR is this?
/kind feature

Special notes for your reviewer:

This is very initial Kubevirt provider implementation, we'll consider and discuss about extending it in future KubeOne releases.

Does this PR introduce a user-facing change? Then add your Release Note here:

Initial implementation of Kubevirt provider for KubeOne. At the moment, the provider only supports deploying machine-controller and operating-system-manager for Kubevirt-based clusters. Terraform integration, CCM, CSI, and other cloud provider specific components are not supported and/or deployed automatically.

Documentation:

TBD

/assign @kron4eg @moadqassem
/hold for discussion and lazy consensus

@kubermatic-bot kubermatic-bot added docs/tbd Denotes a PR that needs documentation (change) that will be done later. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2024
@kron4eg
Copy link
Member

kron4eg commented Oct 25, 2024

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b8924464ebe0a3096cb869068669661f0f092826

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2024
Copy link
Member

@moadqassem moadqassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, moadqassem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member Author

xmudrii commented Oct 31, 2024

/hold cancel
:shipit:

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2024
@kubermatic-bot kubermatic-bot merged commit 7ee5732 into main Oct 31, 2024
15 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.9 milestone Oct 31, 2024
@kubermatic-bot kubermatic-bot deleted the kubevirt branch October 31, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants