-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Kubevirt provider implementation #3416
Conversation
Signed-off-by: Marko Mudrinić <[email protected]>
/approve |
LGTM label has been added. Git tree hash: b8924464ebe0a3096cb869068669661f0f092826
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg, moadqassem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What this PR does / why we need it:
This PR implements the initial and very minimal Kubevirt provider for KubeOne. The purposes of this implementation is to mitigate the issue outlined in #3366, i.e. to allow using machine-controller and operating-system-manager for Kubevirt clusters.
I initially though about reading supported environment variables and putting them in the secret if cloud provider is none, but it has two very big problems:
KUBEVIRT_KUBECONFIG
for the said cluster that uses cloud provider nonekubeone apply
without setting the needed environment variables, in which case the value would be removed from the cluster and machine-controller would start failingBecause of the given reasons, I thought that it's much safer to implement a very minimalistic provider for Kubevirt that doesn't have Terraform integration and support for CCM/CSI, but that can be used as a way to deploy machine-controller and operating-system-manager in a safe and reliable way.
Which issue(s) this PR fixes:
xref #3366
What type of PR is this?
/kind feature
Special notes for your reviewer:
This is very initial Kubevirt provider implementation, we'll consider and discuss about extending it in future KubeOne releases.
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation:
/assign @kron4eg @moadqassem
/hold for discussion and lazy consensus