Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Sidebar and Nav Items for Consistency with Central Dashboard UI #596

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jenny-s51
Copy link
Contributor

Description

Themes PF sidebar and nav items to align with look and feel of Central Dashboard UI.

Before:
Screenshot 2024-11-19 at 17 01 05

After:
Screenshot 2024-11-26 at 1 06 30 PM

How Has This Been Tested?

Visual changes only; run locally and verify that sidebar styling is consistent with Central Dashboard UI.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign griffin-sullivan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…oard

Signed-off-by: Jenny <[email protected]>

remove unused components

apply font color and border to selected nav items

remove unused vars

Signed-off-by: Jenny <[email protected]>

format and remove unused imports
@lucferbux
Copy link
Contributor

Oh wow that's really nice, and I think it's more than enouth to give the kf look and feel.
Btw unrelated, but the main view might be a problem when rendered in kubeflow's central dashboard, we'll need to take a look. cc @Griffin-Sullivan @ederign once we have the central dashboard rendered we can ping jenny to see if there's any point of improvement in the MUI efforts. My guess is that if the ApplicationPage does not get the full height and has margins into the main view is gonna be a little bit out of place compared with other views, but we'll need to check it.

@lucferbux
Copy link
Contributor

Either way this looks really great, thanks a lot @jenny-s51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants