feat: make control namespace field immutable

Signed-off-by: Bence Csati <[email protected]>
kube-logging · Dec 6, 2024 · a67a9a3 · a67a9a3
1 parent 0afa5e5
commit a67a9a3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/api/telemetry/v1alpha1/collector_types.go b/api/telemetry/v1alpha1/collector_types.go
@@ -50,6 +50,10 @@ type MemoryLimiter struct {
 // CollectorSpec defines the desired state of Collector
 type CollectorSpec struct {
 	TenantSelector metav1.LabelSelector `json:"tenantSelector,omitempty"`
+
+	// +kubebuilder:validation:Required
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable, please recreate the resource"
+
 	// Namespace where OTel collector DaemonSet is deployed
 	ControlNamespace string `json:"controlNamespace"`
 	// Enables debug logging for the collector

diff --git a/charts/telemetry-controller/crds/telemetry.kube-logging.dev_collectors.yaml b/charts/telemetry-controller/crds/telemetry.kube-logging.dev_collectors.yaml
@@ -51,6 +51,9 @@ spec:
               controlNamespace:
                 description: Namespace where OTel collector DaemonSet is deployed
                 type: string
+                x-kubernetes-validations:
+                - message: Value is immutable, please recreate the resource
+                  rule: self == oldSelf
               daemonSet:
                 description: DaemonSet is a subset of [DaemonSet in k8s.io/api/apps/v1](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.19/#daemonset-v1-apps),
                   with [DaemonSetSpec replaced by the local variant](#daemonset-spec).

diff --git a/config/crd/bases/telemetry.kube-logging.dev_collectors.yaml b/config/crd/bases/telemetry.kube-logging.dev_collectors.yaml
@@ -51,6 +51,9 @@ spec:
               controlNamespace:
                 description: Namespace where OTel collector DaemonSet is deployed
                 type: string
+                x-kubernetes-validations:
+                - message: Value is immutable, please recreate the resource
+                  rule: self == oldSelf
               daemonSet:
                 description: DaemonSet is a subset of [DaemonSet in k8s.io/api/apps/v1](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.19/#daemonset-v1-apps),
                   with [DaemonSetSpec replaced by the local variant](#daemonset-spec).