feat: make control namespace field immutable

Signed-off-by: Bence Csati <[email protected]>
kube-logging · Dec 6, 2024 · 63a4b7c · 63a4b7c
1 parent 723651b
commit 63a4b7c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/api/telemetry/v1alpha1/collector_types.go b/api/telemetry/v1alpha1/collector_types.go
@@ -52,6 +52,9 @@ type CollectorSpec struct {
 	// TenantSelector is used to select tenants for which the collector should collect data.
 	TenantSelector metav1.LabelSelector `json:"tenantSelector,omitempty"`
 
+	// +kubebuilder:validation:Required
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable, please recreate the resource"
+
 	// Namespace where the Otel collector DaemonSet is deployed.
 	ControlNamespace string `json:"controlNamespace"`
 

diff --git a/charts/telemetry-controller/crds/telemetry.kube-logging.dev_collectors.yaml b/charts/telemetry-controller/crds/telemetry.kube-logging.dev_collectors.yaml
@@ -51,6 +51,9 @@ spec:
               controlNamespace:
                 description: Namespace where the Otel collector DaemonSet is deployed.
                 type: string
+                x-kubernetes-validations:
+                - message: Value is immutable, please recreate the resource
+                  rule: self == oldSelf
               daemonSet:
                 description: DaemonSetOverrides is used to override the default DaemonSet
                   configuration.

diff --git a/config/crd/bases/telemetry.kube-logging.dev_collectors.yaml b/config/crd/bases/telemetry.kube-logging.dev_collectors.yaml
@@ -51,6 +51,9 @@ spec:
               controlNamespace:
                 description: Namespace where the Otel collector DaemonSet is deployed.
                 type: string
+                x-kubernetes-validations:
+                - message: Value is immutable, please recreate the resource
+                  rule: self == oldSelf
               daemonSet:
                 description: DaemonSetOverrides is used to override the default DaemonSet
                   configuration.