Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http): add support for new available parameters #1899

Merged

Conversation

iasha102
Copy link
Contributor

@iasha102 iasha102 commented Dec 24, 2024

fluentd > 1.7 introduced new functionality and parameters that can help many organisations
https://docs.fluentd.org/output/http

This pull request includes several changes to the logging-operator CRD templates and base configurations. The changes mainly involve the addition of new properties to the specifications of clusteroutputs and outputs resources.

Additions to CRD Specifications:

  • Added compress property of type string to clusteroutputs and outputs specifications in multiple files. [1] [2] [3] [4]
  • Added headers_from_placeholders property of type object with additionalProperties of type string to clusteroutputs and outputs specifications in multiple files. [1] [2] [3] [4]
  • Added reuse_connection property of type boolean to clusteroutputs and outputs specifications in multiple files. [1] [2] [3] [4]

Files Affected:

  • charts/logging-operator/charts/logging-operator-crds/templates/logging.banzaicloud.io_clusteroutputs.yaml [1] [2] [3]
  • charts/logging-operator/charts/logging-operator-crds/templates/logging.banzaicloud.io_outputs.yaml [1] [2] [3]
  • charts/logging-operator/crds/logging.banzaicloud.io_clusteroutputs.yaml [1] [2] [3]
  • charts/logging-operator/crds/logging.banzaicloud.io_outputs.yaml [1] [2] [3]
  • config/crd/bases/logging.banzaicloud.io_clusteroutputs.yaml [1] [2] [3]
  • config/crd/bases/logging.banzaicloud.io_outputs.yaml [1] [2] [3]

@OverOrion
Copy link
Contributor

Hey @iasha102, thank you for your PR! 🚀

Could you please sign your commit as required by the CI's DCO check?

…d headers_from_placeholders in HTTPOutputConfig

Signed-off-by: Iacob Nicolaev <[email protected]>
@iasha102 iasha102 force-pushed the feature/update-output-http-params branch from 19d1ebb to d072cea Compare January 4, 2025 12:51
@iasha102
Copy link
Contributor Author

iasha102 commented Jan 4, 2025

done @OverOrion. thanks for review.

@csatib02 csatib02 added the enhancement New feature or request label Jan 5, 2025
Copy link
Member

@csatib02 csatib02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of nits.

pkg/sdk/logging/model/output/http.go Outdated Show resolved Hide resolved
pkg/sdk/logging/model/output/http.go Show resolved Hide resolved
…cy. test(http): added test for new parameters

Signed-off-by: Iacob Nicolaev <[email protected]>
@iasha102 iasha102 force-pushed the feature/update-output-http-params branch from 4d03873 to 89ad4e6 Compare January 6, 2025 08:52
Copy link
Member

@csatib02 csatib02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pepov pepov merged commit 06aca68 into kube-logging:master Jan 9, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants