Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fluentd prom metrics invalid addr #1891

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Dec 18, 2024

Fixes: #1870
Relates: #1890

  • IPv6 was not wired in properly, so it had no effect.
  • Once it was wired in it turned out to be faulty:
[error]: unexpected error error_class=SocketError error=#<SocketError: getaddrinfo: Name or service not known>

@csatib02 csatib02 requested a review from pepov December 18, 2024 12:06
@csatib02 csatib02 self-assigned this Dec 18, 2024
@csatib02 csatib02 marked this pull request as ready for review December 18, 2024 12:20
@csatib02 csatib02 force-pushed the fix/fluentd-prom-metrics-invalid-addr branch from 062e41d to a182ecc Compare December 18, 2024 12:22
Signed-off-by: Bence Csati <[email protected]>
@csatib02 csatib02 force-pushed the fix/fluentd-prom-metrics-invalid-addr branch 3 times, most recently from 242f288 to f9552fd Compare December 18, 2024 13:26
Signed-off-by: Bence Csati <[email protected]>
@csatib02 csatib02 force-pushed the fix/fluentd-prom-metrics-invalid-addr branch from f9552fd to 726d72b Compare December 18, 2024 13:28
@pepov pepov merged commit fd389e6 into master Dec 18, 2024
20 checks passed
@pepov pepov deleted the fix/fluentd-prom-metrics-invalid-addr branch December 18, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants