Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: force HotReload after grace period instead of blocking indefinitely #1886

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

pepov
Copy link
Member

@pepov pepov commented Dec 17, 2024

Forward port of #1885

HotReload pauses all inputs and waits until they finish.
In certain situations this is unacceptable, for example if an output is down for a longer time.
An undocumented option called "Hot_Reload.Ensure_Thread_Safety Off" can be used at the [SERVICE] config to force hotreload after the grace period.
Please note that it might result in a SIGSEGV, but worst case kubelet will restart the container.
See fluent/fluent-bit#7509

Example config:

apiVersion: logging.banzaicloud.io/v1beta1
kind: FluentbitAgent
spec:
  forceHotReloadAfterGrace: true

@pepov pepov added the enhancement New feature or request label Dec 17, 2024
@pepov pepov merged commit 6978331 into master Dec 17, 2024
20 checks passed
@pepov pepov deleted the force-hotreload-grace branch December 17, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants