Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade fluentbit to 2.2.2 #1713

Merged
merged 1 commit into from
Apr 4, 2024
Merged

deps: upgrade fluentbit to 2.2.2 #1713

merged 1 commit into from
Apr 4, 2024

Conversation

aslafy-z
Copy link
Collaborator

@aslafy-z aslafy-z commented Apr 2, 2024 •
edited
Loading

pepov
pepov requested changes Apr 3, 2024
View reviewed changes
Copy link
Member

@pepov pepov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I just realized we have a few more places where we use the fluentbit image, let's update those references as well (simply search for 2.1.8)

@aslafy-z
deps: upgrade fluentbit to 2.2.2
bb6edf8 
Signed-off-by: Zadkiel Aharonian <[email protected]>
Signed-off-by: GitHub <[email protected]>
@aslafy-z aslafy-z force-pushed the deps/fluentbit-2-2-2 branch from e10e095 to bb6edf8 Compare April 3, 2024 07:57
@aslafy-z
Copy link
Collaborator Author

aslafy-z commented Apr 3, 2024

Thanks for the heads up, I will try this at home before making it land in logging-operator!

@aslafy-z aslafy-z marked this pull request as draft April 3, 2024 07:59
@aslafy-z aslafy-z marked this pull request as ready for review April 3, 2024 09:12
@aslafy-z aslafy-z requested a review from pepov April 3, 2024 09:16
@aslafy-z aslafy-z enabled auto-merge (squash) April 3, 2024 09:17
@pepov
Copy link
Member

pepov commented Apr 3, 2024

I can take the tailer part if that helps

@aslafy-z aslafy-z disabled auto-merge April 4, 2024 10:41
@aslafy-z
Copy link
Collaborator Author

aslafy-z commented Apr 4, 2024

I found an issue similar to fluent/fluent-bit#5003 on this version. Will freeze this upgrade until I get some news from fluentbit maintainers.

@aslafy-z aslafy-z marked this pull request as draft April 4, 2024 10:42
@aslafy-z aslafy-z marked this pull request as ready for review April 4, 2024 12:02
@aslafy-z
Copy link
Collaborator Author

aslafy-z commented Apr 4, 2024

Ok, looks like it was an issue with my probe configuration. Ready to merge!

@aslafy-z aslafy-z enabled auto-merge (squash) April 4, 2024 12:02
@aslafy-z aslafy-z requested review from OverOrion and bshifter April 4, 2024 12:03
OverOrion
OverOrion approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@OverOrion OverOrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aslafy-z!

@aslafy-z aslafy-z merged commit 4d83990 into master Apr 4, 2024
19 checks passed
@aslafy-z aslafy-z deleted the deps/fluentbit-2-2-2 branch April 4, 2024 14:52
@pepov pepov added the dependencies Pull requests that update a dependency file label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OverOrion OverOrion OverOrion approved these changes

@pepov pepov pepov approved these changes

@bshifter bshifter Awaiting requested review from bshifter

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aslafy-z @pepov @OverOrion