Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for useragent Fluent filter #1594

Merged

Conversation

csabatuz-chess
Copy link
Contributor

@csabatuz-chess csabatuz-chess commented Nov 26, 2023

This PR adds support for using the https://github.com/bungoume/fluent-plugin-ua-parser Fluent plugin where Fluent plugins are applicable.

Depends on: kube-logging/fluentd-images#88

@csabatuz-chess csabatuz-chess force-pushed the feature/filter-useragent branch from fdfe1c5 to 236e4fc Compare November 26, 2023 13:14
@csabatuz-chess csabatuz-chess marked this pull request as ready for review November 26, 2023 13:16
@csabatuz-chess csabatuz-chess force-pushed the feature/filter-useragent branch 2 times, most recently from 165ce8c to f0f56af Compare November 28, 2023 09:40
@csabatuz-chess csabatuz-chess force-pushed the feature/filter-useragent branch from 2ac1aa1 to 0854830 Compare November 28, 2023 10:28
@csabatuz-chess csabatuz-chess force-pushed the feature/filter-useragent branch 4 times, most recently from 3975157 to 8d311c8 Compare November 28, 2023 12:33
@csabatuz-chess
Copy link
Contributor Author

I'm stuck a bit, can't really interpret the failing E2E test, or connect it to my changeset.

@OverOrion
Copy link
Contributor

I'm stuck a bit, can't really interpret the failing E2E test, or connect it to my changeset.

I reran the CI and it passed, seems like the TestVolumeDrain_Downscale might be flaky, sorry about that!

@pepov pepov force-pushed the feature/filter-useragent branch from 66e1ce8 to fe1c67d Compare December 3, 2023 07:31
@pepov pepov requested a review from OverOrion December 3, 2023 07:44
@csabatuz-chess csabatuz-chess force-pushed the feature/filter-useragent branch from fe1c67d to 96c6e76 Compare December 4, 2023 10:30
@csabatuz-chess
Copy link
Contributor Author

image The directives don't seem to render right in Markdown, that's why I left with ```yaml.

Not sure what's downstream, if this'll be straightened out in the docs, just checking in if this was intended.

@OverOrion
Copy link
Contributor

image The directives don't seem to render right in Markdown, that's why I left with ```yaml.
Not sure what's downstream, if this'll be straightened out in the docs, just checking in if this was intended.

Yeah, that is alright, it is deliberate. The generated *.md files will be consumed by Hugo and it will render it properly (indentation and highlighting wise as well).

@OverOrion OverOrion force-pushed the feature/filter-useragent branch from 96c6e76 to fcb9208 Compare December 4, 2023 14:46
@OverOrion OverOrion merged commit 7c2fa3e into kube-logging:master Dec 5, 2023
16 checks passed
@csabatuz-chess csabatuz-chess deleted the feature/filter-useragent branch December 5, 2023 09:26
@pepov pepov added the feature label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants