Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format attribute overrules type attribute in certain cases #777

Closed
wants to merge 1 commit into from

Conversation

helt
Copy link
Contributor

@helt helt commented Jan 16, 2024

This originated in the observation that a plain file upload leads to a

    Plain_file:
      format: binary
      title: File
      type: string
export type PlainFile = string;

although a "Blob" would be more helpful in my case.

Copy link

changeset-bot bot commented Jan 16, 2024

⚠️ No Changeset found

Latest commit: b2f0611

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kubb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 4:12pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b2f0611:

Sandbox Source
advanced-pet-store Configuration
faker-pet-store Configuration
msw-pet-store Configuration
msw-v2-pet-store Configuration
react-query-pet-store Configuration
react-query-v5-pet-store Configuration
typescript-pet-store Configuration
simple-single-pet-store Configuration
solid-query-pet-store Configuration
svelte-query-pet-store Configuration
swr-pet-store Configuration
vue-query-pet-store Configuration
vue-query-v5-pet-store Configuration
zod-pet-store Configuration
zodios-pet-store Configuration
client-pet-store Configuration

@stijnvanhulle
Copy link
Collaborator

@helt What is the status of this pr? Seems like a nice to have bugfix for Kubb :)

@helt
Copy link
Contributor Author

helt commented Feb 24, 2024

@stijnvanhulle This is not done yet. I need feedback before this can be wrapped up and merged, I think.

I have to close this PR and opend #831. There are also open questions.

@helt helt closed this Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants