Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

732 reduce amount of used generics #735

Closed
wants to merge 2 commits into from

Conversation

xPhentom
Copy link
Collaborator

No description provided.

@xPhentom xPhentom linked an issue Dec 20, 2023 that may be closed by this pull request
3 tasks
Copy link

changeset-bot bot commented Dec 20, 2023

⚠️ No Changeset found

Latest commit: a89bb53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
kubb ✅ Ready (Inspect) Visit Preview Dec 20, 2023 10:31pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a89bb53:

Sandbox Source
advanced-pet-store Configuration
faker-pet-store Configuration
msw-pet-store Configuration
msw-v2-pet-store Configuration
react-query-pet-store Configuration
react-query-v5-pet-store Configuration
typescript-pet-store Configuration
simple-single-pet-store Configuration
solid-query-pet-store Configuration
svelte-query-pet-store Configuration
swr-pet-store Configuration
vue-query-pet-store Configuration
vue-query-v5-pet-store Configuration
zod-pet-store Configuration
zodios-pet-store Configuration
client-pet-store Configuration

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (99fc0e3) 72.15% compared to head (a89bb53) 72.13%.
Report is 2 commits behind head on main.

Files Patch % Lines
...swagger-tanstack-query/src/components/Mutation.tsx 50.00% 1 Missing ⚠️
...es/swagger-tanstack-query/src/components/Query.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #735      +/-   ##
==========================================
- Coverage   72.15%   72.13%   -0.02%     
==========================================
  Files         126      126              
  Lines       12297    12289       -8     
  Branches     1229     1228       -1     
==========================================
- Hits         8873     8865       -8     
  Misses       3415     3415              
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -41,7 +41,7 @@ export function CreatePetsQueryOptions<TData = CreatePets['response'], TQueryDat
* @summary Create a pet
* @link /pets */

export function useCreatePets<TData = CreatePets['response'], TQueryData = CreatePets['response'], TQueryKey extends QueryKey = CreatePetsQueryKey>(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need data and queryKey, without you can not set select with correct types

@stijnvanhulle stijnvanhulle deleted the 732-reduce-amount-of-used-generics branch February 24, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce amount of used generics
2 participants