Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support x-enum-varnames #734

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

chiptus
Copy link
Contributor

@chiptus chiptus commented Dec 18, 2023

closes #731

Copy link

changeset-bot bot commented Dec 18, 2023

⚠️ No Changeset found

Latest commit: 202379a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kubb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 3:46am

@chiptus
Copy link
Contributor Author

chiptus commented Dec 18, 2023

didn't run test locally, something with my env didn't work

Copy link

codesandbox-ci bot commented Dec 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 202379a:

Sandbox Source
advanced-pet-store Configuration
faker-pet-store Configuration
msw-pet-store Configuration
msw-v2-pet-store Configuration
react-query-pet-store Configuration
react-query-v5-pet-store Configuration
typescript-pet-store Configuration
simple-single-pet-store Configuration
solid-query-pet-store Configuration
svelte-query-pet-store Configuration
swr-pet-store Configuration
vue-query-pet-store Configuration
vue-query-v5-pet-store Configuration
zod-pet-store Configuration
zodios-pet-store Configuration
client-pet-store Configuration

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cdd6422) 75.50% compared to head (202379a) 75.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #734      +/-   ##
==========================================
+ Coverage   75.50%   75.83%   +0.33%     
==========================================
  Files         127      127              
  Lines       12402    12416      +14     
  Branches     1297     1313      +16     
==========================================
+ Hits         9364     9416      +52     
+ Misses       3034     2996      -38     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stijnvanhulle
Copy link
Collaborator

@all-contributors please add @chiptus for code

Copy link
Contributor

@stijnvanhulle

I've put up a pull request to add @chiptus! 🎉

@stijnvanhulle
Copy link
Collaborator

@chiptus Thanks a lot for taking up this ticket, looks fine so will merge this later today 👍🏼 .

Since v2 we are using changesets so could you run: pnpm run changeset and follow those steps there to add a changeset?

Thanks

@stijnvanhulle stijnvanhulle merged commit 442cf2d into kubb-labs:main Jan 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support x-enum-varnames
2 participants