More elaborate tests on const keyword #583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
docs: fix install command for swagger-tanstack-query plugin
fix: upgrade js-runtime
…anches--main chore: release main
…gerClient fix: strict type for swagger-client
…anches--main chore: release main
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
… feature/full-const-support # Conflicts: # packages/swagger-ts/src/generators/TypeGenerator.test.ts # packages/swagger-ts/src/generators/TypeGenerator.ts # packages/swagger-ts/src/generators/__snapshots__/TypeGenerator.test.ts.snap
|
Closing because it becomes unmanagable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although touched in #559 to be able to discriminate on types, the implementation is not in line with the spec for
constitself.Specifically, to adhere to the json schema specification section about const, const needs to take precedence over the
typeof a property.I also added a failing test, since I have no clue how to deal with it properly...
@stijnvanhulle How shall we continue? (btw husky pre-commit hooks would keep the format clean...)