fix: discard optional if default is present

kubb-labs · Oct 7, 2024 · 08c384e · 08c384e
1 parent 9707a57
commit 08c384e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/.changeset/selfish-teachers-rhyme.md b/.changeset/selfish-teachers-rhyme.md
@@ -0,0 +1,5 @@
+---
+"@kubb/plugin-zod": patch
+---
+
+Discard `optional()` if there is a `default()` to ensure the output type is not `T | undefined`
diff --git a/packages/plugin-zod/src/components/Zod.tsx b/packages/plugin-zod/src/components/Zod.tsx
@@ -19,13 +19,17 @@ type Props = {
 
 export function Zod({ name, typeName, tree, inferTypeName, mapper, coercion, keysToOmit, description }: Props): KubbNode {
   const hasTuple = tree.some((item) => isKeyword(item, schemaKeywords.tuple))
+  const hasDefault = tree.some((item) => isKeyword(item, schemaKeywords.default))
 
   const output = parserZod
     .sort(tree)
     .filter((item) => {
       if (hasTuple && (isKeyword(item, schemaKeywords.min) || isKeyword(item, schemaKeywords.max))) {
         return false
       }
+      if (hasDefault && isKeyword(item, schemaKeywords.optional)) {
+        return false
+      }
 
       return true
     })