New node to test #11
Closed
New node to test #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktanska
force-pushed
the
new_node_to_test
branch
5 times, most recently
from
329c868 to
e5b27b5
Compare
Updated the maximum device number in md device names from 127 to 1024. The previous limit was causing issues in the automation framework. This change ensures backward compatibility and allows for future scalability. Fixes: 25aa732 ("mdadm: numbered names verification") Signed-off-by: Shminderjit Singh <[email protected]>
If reshape (eg. chunksize migration) is gracefully stopped via SIGTERM the checkpoint is not saved and reshape cannot be resumed due to "data being present in copy area". This is because UNIT_SRC_NORMAL isn't set if SIGTERM occurred. Move SIGTERM handling at the end of the loop to allow saving checkpoint (and state) so reshapes can be properly resumed. Signed-off-by: Mateusz Kusiak <[email protected]>
ktanska
force-pushed
the
new_node_to_test
branch
from
e5b27b5 to
9b851d3
Compare
Fix memory leaks in Examine() reported by SAST analysis. Implement a method to traverse and free all the nodes of the doubly linked list. Replace for loop with while loop in order to improve redability of the code and free allocated memory correctly. Signed-off-by: Anna Sztukowska <[email protected]>
Checkpatch issued a warning due to missing function argument names. Add the names to resolve the warnings. Signed-off-by: Anna Sztukowska <[email protected]>
There are no reasons to keep this interface different than others. Allow to use devnode but keep old way for backward compatibility. Method is added to verify that only devnode or kernel name is used. Signed-off-by: Mariusz Tkaczyk <[email protected]>
ktanska
force-pushed
the
new_node_to_test
branch
9 times, most recently
from
f2a742d to
44b2650
Compare
ktanska
force-pushed
the
new_node_to_test
branch
9 times, most recently
from
f274b80 to
aaaaf1d
Compare
Fix divide_by_zero issue reported by SAST analysis in Detail.c when calling enough() from util.c. Also add missing spaces for better code readability. Signed-off-by: Anna Sztukowska <[email protected]>
ktanska
force-pushed
the
new_node_to_test
branch
5 times, most recently
from
7ec6c05 to
db40ee3
Compare
Documentation/md has moved to Documentation/driver-api/md. Update and and rework sentence. Remove refference to not supported kernel close to updated text. Signed-off-by: Mariusz Tkaczyk <[email protected]>
ktanska
force-pushed
the
new_node_to_test
branch
from
db40ee3 to
c1502d4
Compare
Instead of "remove", "faulty" was called. Fixes: d95edce ("sysfs: add function for writing to sysfs fd") Signed-off-by: Mariusz Tkaczyk <[email protected]>
ktanska
force-pushed
the
new_node_to_test
branch
3 times, most recently
from
cb90c0f to
7a4bf1d
Compare
Rename Monitor.c to mdmonitor.c to avoid errors during compilation on case-insensitive filesystems. Signed-off-by: Kinga Stefaniuk <[email protected]>
ktanska
force-pushed
the
new_node_to_test
branch
2 times, most recently
from
cfe362d to
53d20e5
Compare
scsi_get_serial() function is used only by super-intel.c. Move function to this file and remove sg_io.c file. Signed-off-by: Kinga Stefaniuk <[email protected]>
ktanska
force-pushed
the
new_node_to_test
branch
3 times, most recently
from
20e45f4 to
444a4be
Compare
Operating system vendors are customizing mdmonitor service beacause the default form is not satifying for them (expect SUSE). As a result, support is complicated (maintainers have to check the system) and man page is not detailed. I propose to abandon custom configuration files via sysconfig and keep it inside mdadm.conf only. Detailed comment in service for OSV maintainers is added to help with transition. Signed-off-by: Mariusz Tkaczyk <[email protected]>
Describe how it behaves and how it can be configured to work. Signed-off-by: Mariusz Tkaczyk <[email protected]>
Move mdadm_status_t to mdadm_status.h file. Add status for memory allocation failure. Signed-off-by: Anna Sztukowska <[email protected]>
Clarify a filename is accepted and the need of reloading the udev rules. Small correction on example order. Signed-off-by: Andre Paiusco <[email protected]>
--udev-rules flag is added and point to mdadm.conf man page for further explanations about POLICY. Signed-off-by: Andre Paiusco <[email protected]>
Previously, open_dev() tried to open device in two ways - using /dev and /tmp directory. This method could be used by users which have no access to /tmp directory (e.g. udev) and dev_open() fails which may affect many processes. Remove try to open in /tmp directory. Signed-off-by: Kinga Stefaniuk <[email protected]>
ktanska
force-pushed
the
new_node_to_test
branch
2 times, most recently
from
9b12f95 to
35a4d55
Compare
This test could hang if "check" action is not written to sync_action. If this value didn't appear, test hanged on infinite while loop. Add 5 second timeout to loop. Signed-off-by: Kinga Stefaniuk <[email protected]>
ktanska
force-pushed
the
new_node_to_test
branch
from
35a4d55 to
b33aa21
Compare
Use prepared VM machine in GitHub actions to run mdadm tests on it. Signed-off-by: Kinga Stefaniuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.